coleheflin commented on PR #65879: URL: https://github.com/apache/airflow/pull/65879#issuecomment-5284624043
@potiuk Thanks for the thorough review — all four points addressed: - **`conn-fields` mismatch**: added `managed_identity_client_id` and `workload_identity_tenant_id` to `provider.yaml`'s `conn-fields` for `azure_analysis_services`, matching what `@add_managed_identity_connection_widgets` injects. `Static checks` is green on this now. - **`uv.lock` churn**: regenerated with `uv==0.11.29` (the pinned version) instead of my newer local one — down from ~4,686 lines of platform-marker noise to 176/172. - **Missing `timeout=`**: added a `REQUEST_TIMEOUT` constant and passed it to both `requests.post` and `requests.get` in the hook. - **`RefreshType`/`VALID_REFRESH_TYPES` duplication**: `VALID_REFRESH_TYPES` now derives from `RefreshType` via `frozenset(get_args(RefreshType))`. Rebased onto current `main` as well. The only remaining CI failure (`Generate Datamodels for TaskSDK client`/`AirflowCTL`) reproduces identically on a clean `main` checkout — a `uv` deprecation that's become a hard error in CI's version, unrelated to this PR. --- Drafted-by: Claude Code (Sonnet 5); reviewed by @coleheflin before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
