shivaam commented on PR #70911: URL: https://github.com/apache/airflow/pull/70911#issuecomment-5288707267
> All of the other pages, including the sibling tabs (Dag Run, Task Instances) have a chip filter pattern already implemented. I would suggest that pattern get adopted on the Dags list as well instead of introducing a new/different pattern for this view. I agree that consistency across Dags, Dag Runs, and Task Instances is important. However, I think we should first evaluate which interaction works better, and then decide whether the UX improvement justifies changing the shared pattern and also the use experience. My concern with the current inline pattern is that the filter row can become crowded and reflow as filters are added or edited, causing controls to move. Option B preserves visible, removable, and editable active-filter chips while keeping search and the Filters button in a predictable location. Filter selection is grouped in one panel instead of expanding inline. The underlying component is reusable, so if we agree this is the better direction, I’m happy to migrate the sibling pages as well. If the preference after comparing them is still to retain the current FilterBar pattern, I’m happy to align with that decision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
