mitre88 commented on PR #70530:
URL: https://github.com/apache/airflow/pull/70530#issuecomment-5299676605
Thanks @potiuk — both of your points are now addressed on this branch (head
`853b94ea`):
1. **Provision check kept in `__init__` per #70296** (commit `c66d8c01`):
the constructor now uses the canonical `exactly_one` guard with the correct
polarity and raises `ValueError`, exactly as described in your review:
```python
if not exactly_one(report_name is not None, report_id is not None):
raise ValueError("Please provide exactly one of `report_name` or
`report_id`.")
```
The test is parametrized over both failure modes and asserts
`delete_report.assert_not_called()`, proving the operator bails before touching
the API. The exemption entries in `validate_operators_init_exemptions.txt` and
`known_airflow_exceptions.txt` are removed as the burn-down requires.
2. **Inline test suggestion applied** (commit `853b94ea`):
`op.execute(context=None)` → `op.execute(context={})` in `test_execute`.
@potiuk could you take another look? The prior `CHANGES_REQUESTED` was on an
earlier revision before these commits landed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
