SameerMesiah97 commented on code in PR #71648: URL: https://github.com/apache/airflow/pull/71648#discussion_r3789737353
########## providers/google/tests/unit/google/cloud/sensors/test_bigquery.py: ########## @@ -43,6 +43,39 @@ TEST_IMPERSONATION_CHAIN = ["ACCOUNT_1", "ACCOUNT_2", "ACCOUNT_3"] [email protected]( + ("sensor_class", "trigger_class", "extra_kwargs"), + [ + (BigQueryTableExistenceSensor, BigQueryTableExistenceTrigger, {}), + ( + BigQueryTablePartitionExistenceSensor, + BigQueryTablePartitionExistenceTrigger, + {"partition_id": TEST_PARTITION_ID}, + ), + ], +) [email protected]("airflow.providers.google.cloud.sensors.bigquery.BigQueryHook") +def test_deferred_trigger_receives_impersonation_chain(mock_hook, sensor_class, trigger_class, extra_kwargs): Review Comment: Could we move this test under the respective sensor/trigger test classes rather than having it as a standalone parametrized test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
