uranusjr commented on code in PR #71536:
URL: https://github.com/apache/airflow/pull/71536#discussion_r3793795564
##########
airflow-core/src/airflow/serialization/stub_arg_bindings.py:
##########
@@ -274,6 +319,8 @@ def build_arg_bindings(op: DecoratedOperator) ->
list[dict[str, Any]] | None:
xcom_entry["value_schema"] = value_schema
spec.append(xcom_entry)
continue
+ _reject_nested_xcom(value, task_id, name)
+ value = _to_json_value(value, annotations[name])
Review Comment:
This runs _every_ annotated literal through `adapter.dump_python(...,
mode="json")`. An e.g. Enum or Decimal literal that previously round-tripped
as-is (or was rejected) will now come out as whatever pydantic's json-mode
serializer produces for it. The implied behavioural change may be greater than
it seems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
