dazza-codes commented on issue #6811: [AIRFLOW-6245] Add custom waiters for AWS 
batch jobs
URL: https://github.com/apache/airflow/pull/6811#issuecomment-571888722
 
 
   Did another self-review and most things look OK and test OK.  There is a 
minor revision to how the client polls the AWS Batch job description, so that 
it will fail-fast when it encounters most client errors (except one for 
too-many-requests, then it will retry).  I've briefly considered creating an 
extract-class refactor to pull out an `AwsBatchJob` class that captures only 
the job monitoring responsibility (possibly a persistent state-machine for the 
job), but skipping it because this PR already trims down the operator enough 
and that work could follow this PR if it helps later on.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to