pierrejeambrun commented on code in PR #70783:
URL: https://github.com/apache/airflow/pull/70783#discussion_r3795826374
##########
airflow-core/src/airflow/api_fastapi/app.py:
##########
@@ -60,6 +60,22 @@ def get_cookie_path() -> str:
return API_ROOT_PATH or "/"
+def request_cookie_is_secure(request) -> bool:
Review Comment:
nit: param type?
##########
airflow-core/src/airflow/api_fastapi/auth/managers/base_auth_manager.py:
##########
@@ -180,7 +180,17 @@ def get_fastapi_middlewares(self) ->
list[tuple[_MiddlewareFactory[Any], dict[st
unauthenticated requests when public access is configured) should
override this
method.
"""
- return []
+ return [self._get_jwt_refresh_middleware()]
+
+ def _get_jwt_refresh_middleware(self) -> tuple[_MiddlewareFactory[Any],
dict[str, Any]]:
+ """
+ Return the JWTRefreshMiddleware to refresh the Airflow JWT token.
+
+ :important: The JWTRefreshMiddleware should be included in
get_fastapi_middlewares()
Review Comment:
Nit:
`:important:` This isn't an rst directive.
Maybe use `.. warning::` instead, even if this is private function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
