potiuk commented on PR #67600: URL: https://github.com/apache/airflow/pull/67600#issuecomment-5316790064
Thanks for this, and sorry to close it — this one is a genuinely close call, and it went the other way on the tie-breakers rather than on the work. #71071 makes the same azure-batch 15.x (track 2) migration across the same file set, and the two diffs are close to line-for-line identical. Yours was opened on 27 May, ten weeks earlier, and by the usual convention that would settle it. Two things tip it the other way: - **Credential handling.** This PR keeps `AzureIdentityCredentialAdapter` for the non-shared-key path and needs a `# type: ignore[arg-type]` on the `BatchClient` call. #71071 uses `get_sync_default_azure_credential()` — the provider's own helper — so it gets a native track-2 `DefaultAzureCredential` and no type-ignore. For a migration whose whole point is moving off track 1, dropping the track-1 adapter is the more complete change. - **State.** This branch is currently conflicting with `main` and red on eight-plus legs, including both documentation builds and all four provider-compat runs. #71071 is mergeable and green. That's the "better PR wins" half of the rule doing the work — no judgment on the analysis here, which was correct, and which you reached first. Sorry it landed this way after ten weeks in the queue; that delay is our failure, not yours. Closing in favour of #71071. --- _Drafted by an AI assistant and may contain mistakes — if you think this call is wrong, say so and the PR will be reopened; a human maintainer has the final word._ Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
