arose26 commented on issue #67243:
URL: https://github.com/apache/airflow/issues/67243#issuecomment-5320046208
This looks fixed on `main` and can probably be closed.
`TriggerDAGForm.tsx` now tracks whether the prefill has been applied, and
the effect that syncs the param store's `conf` back into the form field is
gated on that rather than on the absence of a prefill:
```tsx
useEffect(() => {
if (conf && open && (!prefillConfig || hasAppliedPrefill)) {
reset((prevValues) => ({ ...prevValues, conf }));
}
}, [conf, hasAppliedPrefill, prefillConfig, open, reset]);
```
So the original conf is still restored when "Trigger again with this config"
opens the form, and edits made afterwards in the Run Parameters UI now reach
the submitted conf instead of being overwritten by the previous run's values.
There is regression coverage for exactly this path in
`TriggerDAGForm.test.tsx` — *"syncs Advanced Options JSON after Run Parameters
edits in prefilled re-trigger mode"*. On current `main` the file's four tests
pass for me.
Worth a re-test against 3.3.0 by the reporter before closing, since the
original report was on 3.2.1.
---
Drafted-by: Claude Code (Opus 5) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
