Andrushika opened a new pull request, #71784:
URL: https://github.com/apache/airflow/pull/71784

   ## Why
   
   Follow-up PR of #71241. 
   In the prek hook `compile-ui-assets-dev`, the script starts the Vite dev 
server using `Popen`then drops the handles immediately, so a dev server that 
dies later is never detected. 
   What's even worse: on macOS, the dead child's SIGCHLD wakes 
`signal.pause()`, so the script exits 0 and reports success while the browser 
shows a blank page.
   
   ## What
   
   Keep both `Popen` handles and poll them every second instead of calling 
`signal.pause()`. 
   The pre-hook always starts two Vite dev servers. (port 5173 for UI, 5174 for 
Simple auth manager)
   When any of them exits, the script prints which server died with its exit 
code and log file, stops the other one, and exits 1. Polling avoids SIGCHLD 
handling on purpose, since the platform-specific `pause()` wakeup above is what 
made the old failure silent.
   
   related: #71241
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Fable 5)
   
   Generated-by: Claude Code (Fable 5) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to