jason810496 commented on code in PR #70209: URL: https://github.com/apache/airflow/pull/70209#discussion_r3811966930
########## go-sdk/pkg/execution/genmodels/models.gen.go: ########## Review Comment: > (Or at least not incorrectly regenerated.) Make sense for this part, the best way I can come up with is vendoring the the supervisor schema JSON. But this introduce another question: How can we ensure the vendored supervisor schema JSON is correct? We already had e2e test to coverage all the features in Go SDK, so I think it's fine not to have a static check to guard the auto generated schema. If it's a malformed schema, it can't pass the e2e test at all. ########## go-sdk/pkg/execution/genmodels/models.gen.go: ########## Review Comment: > (Or at least not incorrectly regenerated.) Make sense for this part, the best way I can come up with is vendoring the the supervisor schema JSON. But this introduce another question: How can we ensure the vendored supervisor schema JSON is correct? We already had e2e test to coverage all the features in Go SDK, so I think it's fine not to have a static check to guard the auto generated schema. If it's a malformed schema, it can't even pass the e2e test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
