ashb commented on a change in pull request #4751: [AIRFLOW-3607] collected
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r364228229
##########
File path: airflow/models/dagrun.py
##########
@@ -346,7 +331,38 @@ def update_state(self, session=None):
session.merge(self)
session.commit()
- return self.state
+ return ready_tis
+
+ @provide_session
+ def get_ready_tis(self, session, scheduleable_tasks, finished_tasks):
Review comment:
This feels more like a private method, especially since it takes two list of
tasks - I think we should make this "private" `_get_ready_tis` and remove the
`@provide_session` decorator too so that we require to pass in and use the same
DB session.
For consistency with the rest of the code please also make session the last
argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
