amoghrajesh opened a new pull request, #71870:
URL: https://github.com/apache/airflow/pull/71870
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
Adds `example_task_state_store_async.py`, showing an `async def` task that
fetches pages concurrently and checkpoints its progress with `aget`/`aset` so a
retry resumes instead of starting over.
`aget`/`aset` landed in 3.3 but have no example coverage in the repo, and
this is the first `async def` task in `example_dags/`. Two deliberate choices
worth calling out for review:
**The checkpoint is a completed-set, not a high-water cursor.** Both async
examples in
`task-state-store.rst` track a `last_page` cursor, which assumes ordered
sequential
completion. Under `asyncio.gather`, items finish out of order, so a cursor
either skips
unfinished work or repeats finished work. A set is correct at any
concurrency.
**Only the parent coroutine writes the checkpoint.** If each worker
coroutine did its own
`await aset`, the writes would interleave at their await points, each
overwriting a stale
copy of the set, and completed items would silently vanish. So the task
gathers a bounded
batch and the parent checkpoints once per batch. That is the one thing in
the file that
gets a comment, because the bug it avoids leaves no trace.
Progress and the running row total live under a single key so one write
keeps them
consistent, which also means a resumed attempt does not lose the previous
attempt's total.
The staged failure fires only on the first try, so with `retries=2` the Dag
run demonstrates the resume and still ends successfully on a single trigger.
closes: #66842 properly.
### Testing
Try 1
<img width="1674" height="946" alt="image"
src="https://github.com/user-attachments/assets/c1336bd5-d402-4745-8ef6-5d6cea740016";
/>
Try 2
<img width="1674" height="946" alt="image"
src="https://github.com/user-attachments/assets/ad32d836-9901-44b5-8185-c79d062ca8c5";
/>
State store
<img width="1674" height="946" alt="image"
src="https://github.com/user-attachments/assets/ad5a7f0a-ba83-4857-81b8-e988f0ce061a";
/>
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
