amichai07 commented on a change in pull request #4751: [AIRFLOW-3607] collected
trigger rule dep check per dag run
URL: https://github.com/apache/airflow/pull/4751#discussion_r364300910
##########
File path: tests/models/test_dagrun.py
##########
@@ -229,7 +229,7 @@ def test_dagrun_deadlock(self):
start_date=now)
ti_op1 = dr.get_task_instance(task_id=op1.task_id)
- ti_op1.set_state(state=State.SUCCESS, session=session)
+ ti_op1.set_state(state=State.FAILED, session=session)
Review comment:
The trigger rule was defined to be one_failed which means (surprisingly)
that one task has to fail. what happened before the change is: It resulted in
deadlock right away and failed the dag which supposed to be in 'running' state.
Why did it work before the refactor?
probably because it used another session and took the data from the db which
said that the task is 'running' or 'none'
now I might not understand this test fully so please correct me if you think
it is not the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
