vincbeck commented on code in PR #71916:
URL: https://github.com/apache/airflow/pull/71916#discussion_r3832259042
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/event_logs.py:
##########
@@ -73,7 +76,7 @@ def get_event_log(
# clients that currently rely on `when` always being present.
select(Log)
.where(Log.id == event_log_id, Log.dttm.is_not(None))
- .options(joinedload(Log.task_instance), joinedload(Log.dag_model))
+ .options(joinedload(Log.task_instance), joinedload(Log.dag_model),
*eager_load_teams(Log.dag_model))
Review Comment:
> If a dag changes teams do we want the older audit log record to stay with
the original team or update the audit log's team to match the dag?
It is a very good question ... I tend to think we should keep the old name?
Generally in audit, traces and logs we like to see things as they were when
that happened. I'll update the PR. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
