o-nikolas commented on code in PR #71969:
URL: https://github.com/apache/airflow/pull/71969#discussion_r3834417040
##########
providers/amazon/src/airflow/providers/amazon/aws/operators/comprehend.py:
##########
@@ -284,8 +284,8 @@ def __init__(
output_data_config: dict[str, Any] | None = None,
document_classifier_kwargs: dict[str, Any] | None = None,
wait_for_completion: bool = True,
- waiter_delay: int = 60,
- waiter_max_attempts: int = 20,
+ waiter_delay: int = 120,
Review Comment:
Having the delay be 60 was convenient for reasoning about the total number
of minutes, so I'd maybe keep it configured to 60 here. Also, 60*75 leads to a
MUCH bigger timeout than before, going from 20m to well over 2 hours. I think
that is too big of a jump. Dag runs will be blocked for a long long time
unexpectedly as a result.
Maybe double the existing total timeout? so waiter_delay=60 and
waiter_max_attempts=40?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
