dabla commented on code in PR #71350:
URL: https://github.com/apache/airflow/pull/71350#discussion_r3835751192
##########
providers/microsoft/azure/pyproject.toml:
##########
@@ -99,6 +99,7 @@ dependencies = [
# It was added in https://github.com/apache/airflow/pull/47990/files
# maybe this should be set from upstream
"msal-extensions>=1.3.0",
+ "requests>=2.32.0,<3",
Review Comment:
@aaron-y-chen I'm just wondering if the operator couldn't be async/deferred
only like the MSGraphAsyncOperator? That would mean the hook could be purely
written as a native hook, polling and blocking a worker isn't the best approach
anyway, hence why the MSGraphAsyncOperator is purely deferred as well. If so,
that would mean the code would become even more simpler, especially on the
operator side and the hook would be purely async and no more blocking polling
in the worker but forcing usage of trigger mechanism, which is the purpose of
it, triggers are great at polling without blocking the workers. WDYT?
Thank you for the requested changes, beside above remark, the PR is looking
good an clean to me, but before merging I wanted to address above point and see
what your opinion is about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
