fat-catTW commented on code in PR #71654:
URL: https://github.com/apache/airflow/pull/71654#discussion_r3839180546
##########
airflow-core/src/airflow/api_fastapi/common/parameters.py:
##########
@@ -1239,8 +1254,16 @@ def depends_datetime(
upper_bound_lte=upper_bound_lte,
upper_bound_lt=upper_bound_lt,
)
- if filter_name in ("start_date", "end_date"):
- return NullableDatetimeRangeFilter(range_val, attr)
+ attr_name = attribute_name or filter_name
+ if filter_name in ("start_date", "end_date") or (model is DagRun and
attr_name == "start_date"):
+ null_lower_bound_clause: ColumnElement[bool] | None = None
Review Comment:
Thanks, for review!!
I moved `null_lower_bound_clause` to an explicit keyword-only factory
argument and now pass `DagRun.end_date.is_(None)` from the Dag run route,
removing the `DagRun`-specific condition from the shared factory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
