o-nikolas commented on code in PR #71919:
URL: https://github.com/apache/airflow/pull/71919#discussion_r3847282091
##########
airflow-core/src/airflow/api_fastapi/app.py:
##########
@@ -241,6 +244,26 @@ def init_plugins(app: FastAPI) -> None:
log.error("Plugin %s attempted to use reserved url_prefix '%s'",
name, url_prefix)
continue
+ team_name = subapp_dict.get("team_name")
+ if multi_team and team_name is not None:
Review Comment:
Yeah, I could combine those, it needs parens and also still needs the None
check instead of just trushiness (a team name of "" for example would fall
through with your suggestion). So it would have to be something like this:
```python
if multi_team and (team_name := subapp_dict.get("team_name")) is not None:`
```
Look good @vincbeck?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]