Andrushika commented on PR #69937: URL: https://github.com/apache/airflow/pull/69937#issuecomment-5410251687
Thanks! I’ve pushed a commit that does the check in Bundle’s init, so both the interface based and annotation based syntaxes are covered. But this means the warnings show up at runtime in the task logs, not at build time. It is different from what we discussed above, and also different from the implementation in ts-sdk and go-sdk. This is because the java-sdk bundle does not have the ids in its manifest, so doing the validation at build time requires executing the built bundle to extract them. If the build-time check is really needed, I guess we have to embed the IDs into the jar manifest, and that needs further design -- wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
