ferruzzi commented on PR #71850:
URL: https://github.com/apache/airflow/pull/71850#issuecomment-5417574262

   #71802 also edits `serialization/definitions/deadline.py`, so it conflicts 
here too.
   
   When you rebase on top of #70714, the `required_kwargs: set[str] = set()` 
line your diff has above the new `evaluation_timing` is deleted by that PR, and 
the deletion is importnt.  Its replacement treats a present `required_kwargs` 
as an opt-in to the deprecated path, so keeping that line silently routes every 
reference including the built-ins through it rather than failing loudly.  Just 
be careful when you do a rebase or merge conflict.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to