aaron-y-chen commented on code in PR #68134: URL: https://github.com/apache/airflow/pull/68134#discussion_r3860283992
########## providers/apache/spark/src/airflow/providers/apache/spark/hooks/spark_submit.py: ########## @@ -53,6 +53,9 @@ ALLOWED_SPARK_BINARIES = [DEFAULT_SPARK_BINARY, "spark2-submit", "spark3-submit"] _K8S_WAIT_APP_COMPLETION_CONF = "spark.kubernetes.submission.waitAppCompletion" +_K8S_DRIVER_POD_NAME_REGEX = re.compile( + r"(?:^|\s)submission ID spark:([a-z0-9](?:[-a-z0-9]*[a-z0-9])?-driver)(?=\s|$)" Review Comment: I wonder if `spark:` here is actually the namespace rather than a literal prefix, Spark builds the submission ID as `s"$namespace:$driverPodName"`. Maybe we could match `[^\s:]+` instead of `spark:`? https://github.com/apache/spark/blob/fa33ea000a0bda9e5a3fa1af98e8e85b8cc5e4d4/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala#L206-L216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
