xBis7 commented on code in PR #71737:
URL: https://github.com/apache/airflow/pull/71737#discussion_r3864708106
##########
airflow-core/src/airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -34,6 +34,7 @@
from sqlalchemy.orm import Session
from sqlalchemy.sql import ColumnElement
+ from airflow.models.dagrun import FinishedTI
Review Comment:
I don't have a personal opinion on this.
It made sense to me to keep the FinishedTI in the place where it's used but
`taskinstance` also makes sense.
I'm going to leave this question open in case someone else has a preference
and wants to share any thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
