kaxil commented on a change in pull request #6489: [AIRFLOW-3959] 
[AIRFLOW-4026] Add filter by DAG tags
URL: https://github.com/apache/airflow/pull/6489#discussion_r364468582
 
 

 ##########
 File path: airflow/www/app.py
 ##########
 @@ -60,6 +61,11 @@ def create_app(config=None, session=None, testing=False, 
app_name="Airflow"):
         )
     app.secret_key = conf.get('webserver', 'SECRET_KEY')
 
+    session_lifetime_days = 30
+    if conf.has_option('webserver', 'SESSION_LIFETIME_DAYS'):
+        session_lifetime_days = conf.getint('webserver', 
'SESSION_LIFETIME_DAYS')
 
 Review comment:
   We should also add this config to 
https://github.com/apache/airflow/blob/master/airflow/config_templates/config.yml
 and 
https://github.com/apache/airflow/blob/master/airflow/config_templates/default_airflow.cfg
 (If you are using pre-commit hooks `default_airflow.cfg` would be 
auto-generated for you from `config.yml` when you try to commit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to