pierrejeambrun commented on code in PR #72029:
URL: https://github.com/apache/airflow/pull/72029#discussion_r3869958852
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/dags.py:
##########
@@ -148,6 +152,12 @@ def get_dags(
order_by=order_by,
dag_ids=readable_dags_filter.value,
)
+ if is_scheduled is not None:
+ unscheduled_timetable_types = ("NullTimetable", "PartitionedAtRuntime")
Review Comment:
It clutters the view and isn't reusable. (for instance if we want to same
for ui/dags which is the one used in the UI to reflect this in the UI).
I would move this into it's own custom Filter in `parameters.py` so both the
logic filter itself and the hard coded frozenset are contained in a re-usable
piece and moved outside the route logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
