aaron-y-chen commented on code in PR #71711:
URL: https://github.com/apache/airflow/pull/71711#discussion_r3871195165
##########
providers/apache/spark/src/airflow/providers/apache/spark/hooks/spark_submit.py:
##########
@@ -55,6 +55,26 @@
_K8S_WAIT_APP_COMPLETION_CONF = "spark.kubernetes.submission.waitAppCompletion"
+# Values to mask are anchored at a token boundary so the scan stays linear:
without
Review Comment:
It seems the current regex is not strictly linear. For example, a payload
containing many repeated "secret" substrings can still show roughly O(n^2)
behavior:
```python
payload = ("spark-submit", "--arg", "secret" * 10000)
```
I think the current regex already greatly mitigates the original issue, so
perhaps it would be better to soften the linear-time claim in the
comments/title rather than claim strict O(n) complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
