Lee-W commented on code in PR #71403: URL: https://github.com/apache/airflow/pull/71403#discussion_r3871941452
########## providers/common/ai/src/airflow/providers/common/ai/utils/usage.py: ########## @@ -0,0 +1,69 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Helpers for merging the ``max_cost`` convenience parameter into ``UsageLimits``.""" + +from __future__ import annotations + +import dataclasses +from decimal import Decimal, InvalidOperation + +from pydantic_ai.usage import UsageLimits + + +def resolve_usage_limits( + usage_limits: UsageLimits | None, max_cost: Decimal | float | str | None Review Comment: `max_cost` is now gone. `usage_limits` accepts `UsageLimits | dict | None`, is a `template_fields` entry, and `coerce_usage_limits()` builds the real object in `execute()`, driving per-field parsing off `UsageLimits`'s own dataclass field types so a new field of an already-supported type needs no change here. --- The only thing borrwed from KPO is the idea that "accept a templatable dict and build the object at execution time". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
