SameerMesiah97 commented on code in PR #71950:
URL: https://github.com/apache/airflow/pull/71950#discussion_r3874110272
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py:
##########
@@ -104,6 +105,30 @@ def _parse_log_level(message: str) -> int:
return logging.INFO
+def log_message(
Review Comment:
Why is `_log_message `being made public here? Extracting it to a
module-level helper makes sense so it can be shared by PodManager and
KubernetesPodOperator, but it still appears to be an internal implementation
detail. Could we retain the leading underscore unless this is intentionally
becoming part of the provider’s public API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
