ferruzzi commented on PR #72121: URL: https://github.com/apache/airflow/pull/72121#issuecomment-5443479029
I believe Vincent meant to link to #71968, but yes, the fix for this is already in review. For what it's worth, if I were to review this as it sits now: - we would need unit tests for these changes, - this wouldn't have passed the formatting static checks or mypy from what I can tell, - you are also not actually passing `session` in to `get_variable_from_secrets` anywhere, so this wouldn't actually fix the bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
