dabla commented on PR #72130: URL: https://github.com/apache/airflow/pull/72130#issuecomment-5449455507
> Could you review the leftover extra_dejson and sync get_connection hops on the ADF and Synapse async hooks? This is the same AsyncToSync triggerer-loop failure as #55179, now in AzureDataFactoryAsyncHook.get_async_conn / provide_targeted_factory_async and AzureSynapsePipelineAsyncHook.get_async_conn. The question is whether json.loads(conn.extra) on the async path, and get_async_connection in the Synapse hook, is the right leftover fix, and whether leaving the sync hooks on extra_dejson is correct. > > cc @dabla @eladkal @Lee-W > > Drafted-by: Cursor Grok 4.6 (no human review before posting) There is no async `extra_dejson` counterpart, so yes I think it makes senses. We could add one but then we also need to add a backward compat function for the providers, which probably would be the neatest solution. The is also a [PR](https://github.com/apache/airflow/pull/71890) open which addresses another generic issue regarding the async path with connections as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
