pierrejeambrun commented on code in PR #71003: URL: https://github.com/apache/airflow/pull/71003#discussion_r3879353501
########## airflow-core/src/airflow/api_fastapi/core_api/services/public/common.py: ########## @@ -37,6 +37,44 @@ ) +def validate_update_mask(patch_body: BaseModel, update_mask: list[str] | None) -> list[str] | None: + """ + Reject ``update_mask`` entries that name no field of ``patch_body``. + + Every caller narrows the patch down with ``set(update_mask)``, which drops an entry matching Review Comment: This should be part of the query param validator. We should extract a custom query param for `updatemask` in `parameters.py` which will do the validation, without having to call validate everywhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
