henry3260 commented on issue #56034:
URL: https://github.com/apache/airflow/issues/56034#issuecomment-5451362144
Scope note, since the metrics that ship differ from the three listed in the
description.
#64523 emits two metrics for `/api/v2` and `/ui` requests:
- `http_requests_total` (counter)
- `http_request_duration_milliseconds` (timer)
both tagged with `method`, `route` (the FastAPI route template) and
`status_family` (`2xx`/`4xx`/`5xx`).
That still covers the three use cases here:
- **latency (p95/p99)** — `http_request_duration_milliseconds`, broken down
by route
- **QPS per endpoint** — `http_requests_total`, broken down by route
- **error spikes** — `http_requests_total` filtered on
`status_family="5xx"`, rather than
a dedicated errors metric
The separate errors counter was dropped on purpose: it would duplicate
series that `status_family` already distinguishes, and keeping the tag set
small was the main constraint on this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
