saitejabandaru-in commented on PR #71840: URL: https://github.com/apache/airflow/pull/71840#issuecomment-5457393786
@moomindani Thank you for the detailed and incredibly helpful review! I have addressed all the feedback: 1. Replaced `BaseHook.aget_connection` with `get_async_connection` from `compat` to preserve support for Airflow 3.0.x and 2.x. 2. Renamed `adatabricks_conn` to `_get_conn_async` and refactored the async entrypoints to resolve it once and use it (reducing duplicate I/O). 3. Reverted the `AirflowException` raises back to `ValueError` to match their sync counterparts and satisfy the `check-no-new-airflow-exceptions` pre-commit hook. 4. Fixed the regex mismatch in `test_a_get_federated_token_missing_client_id` caused by the exception type change. 5. Ran `ruff format` across the hook and test files. Please let me know if there is anything else I can improve! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
