potiuk commented on PR #71305: URL: https://github.com/apache/airflow/pull/71305#issuecomment-5462883507
Both addressed in 178b035 — thanks, these were good catches. **Transient `gh` failures:** `get_latest_workflow_run_id` now takes `exit_on_error` (default `True`, so the pre-dispatch baseline lookup still fails fast). The polling loop in `wait_for_new_workflow_run` passes `False`, so a failed lookup logs a warning and retries until the deadline instead of aborting the publishing chain. **Non-dispatch runs:** added `--event workflow_dispatch` to `gh run list` — you're right that airflow-site's `build.yml` also runs on push and pull_request, and such a run registering between the two lookups would have a higher id than the baseline and be mistaken for ours. Every caller of this path dispatches via `gh workflow run`, so the filter is safe across the board, and it composes with the id comparison rather than replacing it (id monotonicity still separates our dispatch from a concurrent manual one). Rebased on latest main while I was at it. --- Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
