slice-soupam commented on PR #72297: URL: https://github.com/apache/airflow/pull/72297#issuecomment-5470333371
For context: `SetXCom` support for the Dag processor was explicitly deferred once before, in #55665. At the time: > I don't think DagProc should support delete or set xcom -- those need a specific run ID to operate and I can't really think of a case where that makes sense (i.e. would be used today) in dag processing context. No one has (yet) complained about those not existing, so lets hold off on adding those until someone does complain. > > Do you have an example dag file that might trigger them at parse time? > > For Dag processor specifically, lets add them when someone specifically asks for it This PR is that case: a Dag-level `on_failure_callback` calling `ti.xcom_push(key="slack_thread_ts", ...)` (a `TaskCallbackRequest`, so it carries a concrete `dag_id`/`run_id`/`task_id`, not an arbitrary run) hung until `dag_file_processor_timeout` in production because `SetXCom` wasn't handled. #72008 fixes the hang generically for any unsupported type; this PR is the "someone specifically asked for it" follow-up for `SetXCom` itself. `DeleteXCom` and everything else on that original list remain unsupported here, consistent with the original discussion — only `SetXCom` has a concrete, reported need behind it. --- Drafted-by: Claude Code (Sonnet 5) (no human review before posting) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
