SameerMesiah97 commented on code in PR #70103:
URL: https://github.com/apache/airflow/pull/70103#discussion_r3890286076
##########
providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake.py:
##########
@@ -64,6 +65,39 @@
from airflow.providers.openlineage.sqlparser import DatabaseInfo
+class SnowparkContainerJobStatus(str, Enum):
Review Comment:
> So I had originally placed them in the trigger as you mentioned, but it
was pointed it out in one of the review comments above that it would make more
sense to keep the enum/status sets with the hook as importing shared
abstractions from the trigger module might look a bit strange. I think it's
fine where it is but I'm happy to move em back to the trigger if you feel they
are suited better there.
I think it is ultimately down to individual preferences. I do not feel
strongly about the placement even though I made that comment. It’s up to you
really
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
