PrakshiGoyal10 commented on PR #69998: URL: https://github.com/apache/airflow/pull/69998#issuecomment-5474619979
Thanks for the approval and for measuring each step rather than taking the description's word for it — the verification on the standalone-task path is much appreciated. Good catch on the new Airflow-2 test never executing — you're right, the `AIRFLOW_V_3_0_PLUS` and `RUNNING_TESTS_AGAINST_AIRFLOW_PACKAGES` guards cover every environment between them, so it skips everywhere, same as the neighbouring `*_airflow2` tests. I left it in that shape for consistency with those, but I take the point that it reads as a live guard for the fix when it isn't. Noted the pre-existing Airflow-2 repair-all `databricks_task_key` clear-parity item as out of scope for this PR. One question on merging: the PR still shows `REVIEW_REQUIRED` / blocked despite the approval — is a committer approval (or a second reviewer) still needed to land it, or is there anything else you'd like from me first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
