qaziashikin opened a new pull request, #72335:
URL: https://github.com/apache/airflow/pull/72335
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
## Description
Under MWAA Serverless (Overdrive), `dag_id` is overwritten with a
per-execution UUID for
tenant isolation, so the operator was passing the execution UUID as
`workflow_name` to
`StartNotebookRun` instead of the actual workflow name. This breaks the SMUS
UI's ability
to link a notebook run back to the workflow that triggered it.
MWAA Serverless now injects the workflow name as a DAG param under the key
`mwaa_serverless_workflow_id`. Read from that param when set, fall back to
`context["dag"].dag_id` for standard SMUS Workflows and open-source Airflow.
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (please specify the tool below)
Claude Opus 4.7
## Testing
Ran system test:
```
qashikin@c889f3b847e4 airflow % .venv/bin/python -m pytest --system -v
--with-db-init \
--setup-timeout=3600 --execution-timeout=3600 --teardown-timeout=3600 \
providers/amazon/tests/system/amazon/aws/example_sagemaker_unified_studio_notebook.py
======================================== test session starts
=========================================
platform darwin -- Python 3.11.14, pytest-9.1.1, pluggy-1.6.0 --
/Volumes/workplace/airflow/.venv/bin/python
cachedir: .pytest_cache
rootdir: /Volumes/workplace/airflow
configfile: pyproject.toml
plugins: mock-3.15.1, instafail-0.5.0, time-machine-3.4.0, unordered-0.8.0,
cov-7.1.0, timeouts-1.2.1, xdist-3.8.0, asyncio-1.4.0, custom-exit-code-0.3.0,
anyio-4.14.2, icdiff-0.9, rerunfailures-16.6, kgb-7.3, requests-mock-1.12.1
asyncio: mode=Mode.STRICT, debug=False,
asyncio_default_fixture_loop_scope=function,
asyncio_default_test_loop_scope=function
setup timeout: 3600.0s, execution timeout: 3600.0s, teardown timeout: 3600.0s
collected 1 item
providers/amazon/tests/system/amazon/aws/example_sagemaker_unified_studio_notebook.py::test_runel-common/src/tests_common/test_utils/system_tests.py
PASSED [100%]
========================== 1 passed, 1 warning in 290.96s (0:04:50)
===========================
```
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
