bbovenzi commented on code in PR #72161:
URL: https://github.com/apache/airflow/pull/72161#discussion_r3895803012
##########
airflow-core/src/airflow/ui/src/layouts/Details/Grid/GridButton.tsx:
##########
@@ -16,13 +16,13 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { Flex, type FlexProps } from "@chakra-ui/react";
+import { Box, Flex, type FlexProps, Text, VStack } from "@chakra-ui/react";
import { useTranslation } from "react-i18next";
import { Link } from "react-router-dom";
import type { DagRunState, TaskInstanceState } from
"openapi/requests/types.gen";
-import { BasicTooltip } from "src/components/BasicTooltip";
Review Comment:
We probably want to delete the BasicTooltip entirely and replace it in
Calendar too
##########
airflow-core/src/airflow/ui/src/layouts/Details/Grid/GridButton.tsx:
##########
@@ -50,54 +50,70 @@ export const GridButton = ({
}: Props) => {
const { t: translate } = useTranslation();
- const tooltipContent = (
- <>
- <Time datetime={runAfter} />
- <br />
- {translate("common:runId")}: {runId}
- <br />
- {translate("state")}:{" "}
- {state ? translate(`common:states.${state}`) :
translate("common:states.no_status")}
- <br />
- {translate("duration")}: {renderDuration(duration)}
- </>
- );
-
- return isGroup ? (
- <BasicTooltip content={tooltipContent}>
- <Flex
- background={`${state}.solid`}
- borderRadius={2}
- height="10px"
- minW="14px"
- pb="2px"
- px="2px"
- {...rest}
- >
- {children}
- </Flex>
- </BasicTooltip>
- ) : (
- <BasicTooltip content={tooltipContent}>
- <Link
- replace
- to={{
- pathname: `/dags/${dagId}/runs/${runId}/${taskId === undefined ? ""
: `tasks/${taskId}`}`,
- search: searchParams.toString(),
- }}
- >
- <Flex
- background={`${state}.solid`}
- borderRadius={2}
- height="10px"
- pb="2px"
- px="2px"
- width="14px"
- {...rest}
- >
- {children}
- </Flex>
- </Link>
- </BasicTooltip>
+ return (
+ <Tooltip
Review Comment:
Let's add `lazyMount unmountOnExit` params here for large grids
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
