Kunal8954 commented on PR #72406: URL: https://github.com/apache/airflow/pull/72406#issuecomment-5508983728
Yeah, fair point — let me split this into two things. The HTTPError catch is the actual fix here. That's the regression the issue is about: _check_response_status_and_data started raising HTTPError on a 404, but the loop was still only catching KeyError, so the "give it a second, the run isn't registered yet" tolerance from #10031 quietly broke. The KeyError catch was already there on main before this PR (also came in with #60688) — I left it alone rather than ripping it out, since that felt like a separate change from what the issue is reporting. But you're asking the right question. I don't actually have a case where get_pipeline_workflow returns a 200 with no "status" key in it, so I can't say for sure it's reachable. If you've seen it happen, or have a hunch where, I'm happy to dig in. Auditing all of #60688 for similar issues is a good shout, but honestly feels like its own effort rather than something to fold into this PR. If a maintainer wants that done I'm up for picking it up separately, just didn't want to scope-creep this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
