github-actions[bot] opened a new pull request, #72441:
URL: https://github.com/apache/airflow/pull/72441

   The scheduler Deployment copies the executor value into a pod label and 
sanitises "," and ":" on the way through. Multi-team executor config uses ";" 
and "=" as its separators, and neither is legal in a Kubernetes label value, so 
a chart configured the documented multi-team way renders a label the API server 
rejects and the deploy fails outright.
   
   Why this is worth fixing rather than working around: multi-team executors 
are what the edge worker's --team-name flag depends on. EdgeExecutor stamps 
each edge_job row with its executor's team, and a worker started with 
--team-name only picks up jobs whose team matches. Without a per-team executor 
entry the jobs get stamped NULL, the worker sits there reporting it has no 
work, and the tasks stay queued.
   
   There isn't a good way around it from values.yaml. Quoting doesn't help, 
because the restriction is on the characters in the label rather than on the 
YAML. Setting config.core.executor instead is refused by the check in 
NOTES.txt. Overriding the label through .Values.labels does render, but it 
stamps the label on every object in the chart and breaks the migrations Job, 
whose pod template can't be changed in place.
   
   Sanitising ";" and "=" alongside the separators the chart already handles 
keeps the label legal while airflow.cfg still gets the real value.
   (cherry picked from commit 7036d244b138463acc7849d5e38b419cd800e990)
   
   Co-authored-by: KidAmnesiac1 <[email protected]>
   Co-authored-by: Przemysław Mirowski 
<[email protected]>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to