ashb commented on a change in pull request #7085: [AIRFLOW-6334] Use classes
instead list of string in executors
URL: https://github.com/apache/airflow/pull/7085#discussion_r364721618
##########
File path: airflow/executors/base_executor.py
##########
@@ -232,14 +255,14 @@ def get_event_buffer(self, dag_ids=None) ->
Dict[TaskInstanceKeyType, Optional[s
def execute_async(self,
key: TaskInstanceKeyType,
- command: CommandType,
+ deferred_run: LocalTaskJobDeferredRun,
queue: Optional[str] = None,
Review comment:
Oh right all the `ignore_*` etc. Gotcha. I somehow managed to forget all of
those.
I think we should avoid "queue" here as Airflow already has a concept of
queues, and this is not what we are dealing with at this level.
I think Celery calls this a "Request"
http://docs.celeryproject.org/en/latest/reference/celery.worker.request.html -
how about TaskExecutionRequest. That or SomethingMessage?
`TaskExecutionMessage`.
(Sorry to be pick about names, but I think it's important here.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
