weiyu1029 opened a new pull request, #72453:
URL: https://github.com/apache/airflow/pull/72453

   <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   ### Description
   
   Forward `region_name`, `verify`, and `botocore_config` from
   `SageMakerUnifiedStudioNotebookOperator` to
   `SageMakerUnifiedStudioNotebookTrigger` when execution is deferred.
   
   Previously, these AWS hook configuration values were not forwarded to the
   trigger. As a result, the triggerer could construct its hook using different
   AWS configuration from the operator that originally started the notebook run,
   including potentially polling a different AWS region.
   
   This change ensures that the deferred trigger receives and serializes the 
same
   AWS hook configuration used by the operator.
   
   ### Tests
   
   Extended the deferrable operator unit test to verify that:
   
   - `region_name` survives trigger serialization.
   - `verify` survives trigger serialization.
   - `botocore_config` survives trigger serialization.
   - The derived `waiter_max_attempts` behavior remains unchanged.
   
   Tested locally with:
   
   ```bash
   breeze testing providers-tests 
providers/amazon/tests/unit/amazon/aws/operators/test_sagemaker_unified_studio_notebook.py
   
   breeze testing providers-tests 
providers/amazon/tests/unit/amazon/aws/triggers/test_sagemaker_unified_studio_notebook.py
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [X] Yes (please specify the tool below)
   <!-- Generated-by: ChatGPT following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to