vitorantoniazzi opened a new pull request, #72457:
URL: https://github.com/apache/airflow/pull/72457

   ## Summary
   
   cloudant_fake.py is a pair of no-op stubs for CloudantV1 and 
CouchDbSessionAuthenticator. They were there for the Python 3.9 import 
fallback, back when the hook couldn't assume ibmcloudant was installed.
   
   That situation is gone. #52072 dropped 3.9 support and took the 
sys.version_info guard with it, and the hook now imports from ibmcloudant 
directly.
   
   I grepped the whole repo for anything touching the stub and came up empty, 
other than its own line in OVERLOOKED_TESTS. So this deletes the file and drops 
the entry.
   
   Worth saying out loud: the issue author asked for a second opinion from 
someone with context on the original optional-import setup before the file goes 
away. This PR is that deletion, so take it as the invitation. If anyone knows a 
reason to keep the stub around, say so and I'll close this.
   
   Closes: #72269
   
   ## Test Plan
   
   - A repository-wide search for `cloudant_fake` returns only the 
`OVERLOOKED_TESTS` entry that this PR removes.
   - `providers/cloudant/src/airflow/providers/cloudant/hooks/cloudant.py` 
imports `CloudantV1` and `CouchDbSessionAuthenticator` directly from 
`ibmcloudant`, with no `sys.version_info` guard left.
   - I have not run `breeze run mypy providers/cloudant` locally. Nothing 
imports the deleted module, so it cannot take part in type checking anything 
else, but the CI mypy run is the real confirmation here.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Change drafted with Claude Code (Opus 5); reviewed and verified by 
@vitorantoniazzi
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to