Kunal8954 commented on PR #72470: URL: https://github.com/apache/airflow/pull/72470#issuecomment-5527348848
> By the way, > > 1. Regarding Airflow's PR title conventions, we usually just write a clear and concise description of what the PR does, rather than using prefixes like fix:, perf:, or feat:. I'd recommend checking out existing Airflow PR titles or the [contributing guide](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst) for reference. (CI will also check the PR title) > 2. I think we should need a regression test for this Thanks for both points. 1. Title updated - dropped the `fix:` prefix per the contributing guide (checked contributing-docs/05_pull_requests.rst, which explicitly says no conventional-commit prefixes, imperative mood only). 2. Added a regression test at airflow-core/tests/unit/api_fastapi/common/test_headers.py covering the schema (examples not enum, default preserved) and the header negotiation behavior itself. 13 passed locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
