sivavarma-x commented on code in PR #69761:
URL: https://github.com/apache/airflow/pull/69761#discussion_r3936081327
##########
shared/plugins_manager/src/airflow_shared/plugins_manager/plugins_manager.py:
##########
@@ -85,6 +87,52 @@ class AirflowPluginException(Exception):
"""Exception when loading plugin."""
+# Kept in sync with ``BaseDestinationLiteral`` in
``airflow.api_fastapi.core_api.datamodels.plugins``
Review Comment:
Agree with Jason's direction here, keeping a single definition in
`plugins_manager.py` and importing it into the `datamodels` layer feels cleaner
than maintaining two identical Literal definitions with a "kept in sync"
comment.
Pushed in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
