realtimetodie commented on PR #72458: URL: https://github.com/apache/airflow/pull/72458#issuecomment-5546139833
Yes, you are right. My initial description was ambiguous. I was too focused on my telemetry backend, which can find the root span based on attributes from child spans. The cleaner OpenTelemetry design is to attach the DAG tags only to the root dag_run.* span. The following are the only two attributes present everywhere: - `airflow.dag_id` - `airflow.dag_run.run_id` In my opinion, duplicating the DAG tags as attributes onto every task_run, worker and trigger span is unnecessary. However, it is technically possible. | Span | DAG tags available? | | ---------------- | ---------------------- | | `dag_run` (root) | Yes | | `task_run` | Yes, with extra lookup | | `worker` | Yes | | `trigger` | No, not without changing the internal API | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
