fat-catTW commented on PR #72487: URL: https://github.com/apache/airflow/pull/72487#issuecomment-5549282479
Thanks for the contribution! I think this test should use an independent expected list instead of parametrizing from `utils.__all__`. Right now `utils.__all__` is derived from `_IMPORT_MAP`, so the test only checks the exports that the implementation currently advertises. If an expected compat export like `prepare_virtualenv`, `SkipMixin`, or one of the XCom constants were accidentally removed from `_IMPORT_MAP`, it would also disappear from `__all__`, and this test would still pass without noticing. Could we make the expected public exports explicit in the test, then assert both `set(utils.__all__)` and that each expected name resolves successfully? That would make the test protect the actual compatibility contract before removing this file from `OVERLOOKED_TESTS`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
