LE0-Lin commented on code in PR #72560:
URL: https://github.com/apache/airflow/pull/72560#discussion_r3941307638
##########
providers/google/tests/unit/google/cloud/hooks/vertex_ai/test_pipeline_job.py:
##########
@@ -246,6 +246,26 @@ def test_list_pipeline_jobs(self, mock_client) -> None:
)
mock_client.return_value.common_location_path.assert_called_once_with(TEST_PROJECT_ID,
TEST_REGION)
+ @pytest.mark.parametrize("method_name", ["run_pipeline_job",
"submit_pipeline_job"])
+ @pytest.mark.parametrize("reserved_ip_ranges", [None, [], ["range-1",
"range-2"]])
+
@mock.patch(PIPELINE_JOB_STRING.format("PipelineJobHook.get_pipeline_job_object"))
+ def test_pipeline_job_forwards_reserved_ip_ranges(
Review Comment:
Thanks for the suggestion. I split the coverage into separate tests for
`run_pipeline_job` and `submit_pipeline_job`, and added `none`, `empty`, and
`multiple` IDs so failures are easier to identify. The full hook test file
passes (25 tests).
---
Drafted-by: OpenAI Codex (reviewed by @LE0-Lin)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
