Andrushika commented on PR #72569:
URL: https://github.com/apache/airflow/pull/72569#issuecomment-5553882525

   One more thing I found while digging into this... The providers mypy hooks 
(`scripts/ci/prek/mypy.py` and `mypy_folder.py`) pass 
`INCLUDE_MYPY_VOLUME=true` to `breeze run`, but `breeze run` has no 
`--include-mypy-volume` option. The env var only binds to `breeze shell`. So 
the cache volume is never mounted there either, and since `breeze run` uses 
`--rm`, I think the mypy cache is rebuilt from scratch on every hook run.
   
   I have not timed it yet, so this is from reading the code. I see two 
options: add the mypy volume support to `breeze run`, or drop the env var and 
the comment from the two scripts so they stop suggesting a cache that does not 
exist. 
   
   Happy to do either in a follow-up PR, keeping this one small.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to